More fixes to UPGRADING #16415
More fixes to UPGRADING #16415
Conversation
| should be replaced with checks for `false`. | ||
|
|
||
| - DOM: | ||
| . Added DOMNode::compareDocumentPosition() and DOMNode::DOCUMENT_POSITION_* |
There was a problem hiding this comment.
This was added because last time some stuff got added, I got a complaint that adding the $id property breaks BC because someone was having a user class that implemented $id (differently).
There was a problem hiding this comment.
This was added because last time some stuff got added, I got a complaint that adding the $id property breaks BC because someone was having a user class that implemented $id (differently).
Okay, I'll make a note to add a generic warning about this in the incompatibility page.
| - GMP: | ||
| . Casting a GMP object to bool changed so that 0 becomes false and everything else | ||
| becomes true. | ||
| RFC: https://wiki.php.net/rfc/fix_up_bcmath_number_class |
There was a problem hiding this comment.
Not sure about this one; might better be left in the incompatible section.
There was a problem hiding this comment.
The thing is that it wasn't possible to cast an instance of a GMP object to bool, it would trigger a E_RECOVERABLE_ERROR diagnostic.
There was a problem hiding this comment.
I should just reword it like I did in the migration guide PR.
There was a problem hiding this comment.
Thank you!
(We should not forget to add GMP to https://www.php.net/manual/en/language.types.boolean.php#language.types.boolean.casting.)
Girgias
force-pushed
the
8.4-upgrading-3
branch
from
752684d to
f52a102
Compare
3 participants
I don't understand why we added the following note:
As this is "standard", if the migration guide should mention this then it should just link to the new functions, classes, and constant pages. As having this is a "generic" incompatibility.